Skip to content

Create addon wrapper#112

Merged
dajimenezriv-internxt merged 3 commits intomasterfrom
create-addon-wrapper
Feb 3, 2025
Merged

Create addon wrapper#112
dajimenezriv-internxt merged 3 commits intomasterfrom
create-addon-wrapper

Conversation

@dajimenezriv-internxt
Copy link
Contributor

@dajimenezriv-internxt dajimenezriv-internxt commented Feb 1, 2025

What

  1. This PR creates the addon wrapper, that should be the only thing exportable from the node-win repository (Move node-win functionality to drive-desktop #109).
  2. It also adds safe parse of types for the addon (Addon return values are inconsitent #101) so we can start checking that the return types from C++ are consistent.
  3. Applies the function fixPath to all paths in virtual drive. Now all paths are converted to absolute windows path.
  4. 7 new tests have been added to test the fixPath functionality.

What tests I did?

  1. Running "yarn vitest:once". ✅
  2. Testing synchronization (hydrate, dehydrate, fetch data with double click, add file, delete file). ✅

@dajimenezriv-internxt dajimenezriv-internxt self-assigned this Feb 1, 2025
@dajimenezriv-internxt dajimenezriv-internxt marked this pull request as ready for review February 1, 2025 00:58
@dajimenezriv-internxt dajimenezriv-internxt merged commit 29eeb6c into master Feb 3, 2025
1 check passed
@dajimenezriv-internxt dajimenezriv-internxt deleted the create-addon-wrapper branch February 3, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants